Convert exising class names-CSDN问答

来自 : CSDN技术社区 发布时间：2021-03-24

私信 访问主页

weixin_39966765 2020-11-27 14:13 首页 开源项目 Convert exising class names

Fixes issue #295.Renames classes and files, and fixes guards.This PR does not touch the 3rd party folder.

该提问来源于开源项目 newsboat/newsboat

点赞 写回答 收藏 复制链接分享 删除 再等等 结题 再想想 11条回答

私信 访问主页

weixin_39887925 3月前

Ok! Please mention this PR s number in the new one so they re linked and we can reconstruct how the decisions were made.

点赞 评论 复制链接分享

私信 访问主页

weixin_39966765 3月前

I m going to close this request and open a new one for the updated PR.

点赞 评论 复制链接分享

私信 访问主页

weixin_39519769 3月前

Hey, don t worry about that, I should have probably stop earlier then I did. Thank you for the work, I m sure next try will be a good one.

点赞 评论 复制链接分享

私信 访问主页

weixin_39966765 3月前

Happy to help I love newsboat. I m just sorry I wasted so much of time.

点赞 评论 复制链接分享

私信 访问主页

weixin_39887925 3月前

Forgot to mention: GitHub notifies everyone if new commits are pushed, but not if they re force-pushed. So please drop a comment if you force-push, so we can take a look again.

Also forgot to thank you, which is a shame. Thanks for taking the time to work on this, it s very much appreciated!

点赞 评论 复制链接分享

私信 访问主页

weixin_39966765 3月前

Got it, I ll start this one over.

点赞 评论 复制链接分享

私信 访问主页

weixin_39887925 3月前

I agree with —a lot more care should be taken when renaming. In particular, one shouldn t change the names of SQL tables and names of Newsboat settings, because these are part of our public interface which should be stable.

I m sorry, but given how much collateral damage is done, I think it might be better to start from scratch, and use much more restrictive regexes. Take a look at \\ and \\ if you re using sed (they re word boundaries ). Feel free to force-push the new changes.

Also, please don t merge master into your pull request, because this makes it harder to review. For a PR like yours, you should either:- rebase, so your commits are on top of the latest changes; or- do nothing, and I ll resolve the conflicts when I merge it into master.

点赞 评论 复制链接分享

私信 访问主页

weixin_39519769 3月前

I m not sure if I should proceed with the review, there are a lot of variable names, comments etc. that got hit by what seems like a ricochet of word changes. They are all probaly should get fixed before merge.

点赞 评论 复制链接分享

私信 访问主页

weixin_39966765 3月前

Take your time its a huge change.

点赞 评论 复制链接分享

私信 访问主页

weixin_39887925 3月前

Hi! Thank you for the pull request! I feel a bit under the weather today,so I ll review this tomorrow evening. Sorry about the delay.

On Mon, 1 Oct 2018, 15:44 Coveralls, wrote:

[image: Coverage Status] https://coveralls.io/builds/19279559

Coverage decreased (-0.1%) to 39.537% when pulling 0cefcc8https://github.com/newsboat/newsboat/commit/0cefcc8edc87651ea029162b841cc5b960898dbfon zaowen:master into 69ba7a3https://github.com/newsboat/newsboat/commit/69ba7a37440d6dc08cfa81db771d413eae728d3fon newsboat:master.

You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHubhttps://github.com/newsboat/newsboat/pull/298#issuecomment-425893679,or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHQW0LwjG18lmZWHLMVc_JnE7UZLiACks5ugg4rgaJpZM4XB8H8 评论 复制链接分享

私信 访问主页

weixin_39629969 3月前

Coverage increased ( 0.009%) to 39.693% when pulling 0cefcc8edc87651ea029162b841cc5b960898dbf on zaowen:master into 69ba7a37440d6dc08cfa81db771d413eae728d3f on newsboat:master.

点赞 评论 复制链接分享 提交 再想想 采纳 为你推荐 迭代私有属性中的数组保持 php 2个回答 点击登录 提问题 欢迎建议意见 . 如何写高质量提问和回答？ 采纳榜7天 被采纳次数 ProfSnail 25 幻灰龙 19 qq_34124780 154 coagenth 115 规则边缘 116 GoCityPass新加坡曼谷通票 117 cpp_learner 98 Jack_Yang(数据分析及可视化) 99 我不喜欢这个世界 810 天际的海浪 6 加急问题 500 500 基于tensorflow的模型做预测时，cpu占用率过高，如何降低程序的cpu占用率？ 500 如何将蓝鲸智云社区版6.0.2的流程服务和监控平台(SAAS应用）从中文切换到英文 100 unity 设置Animation的culling type 导致游戏崩溃 100 java实现下面两个算法 100 ECDSA加密算法中，签名和验证都是需要时间的，那其时间复杂度怎么用椭圆曲线参数如阶或模p来表示呢？ 75 数据库只有myd文件没有frm,myi文件，怎么打开呢 51 利用Adams联合matlab仿真求运动学反解问题 50 labview使用datasocket与c/c#程序的通信 50 如何用C语言实现凯撒密码对文本文件(.txt)的读取穷举暴力破解？ 50 已知地图GPS坐标点A和坐标点B，获取A点往B点直线走一定距离的坐标点经纬度？